Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: signing behind interface #20

Merged
merged 18 commits into from
Oct 14, 2024
Merged

chore: signing behind interface #20

merged 18 commits into from
Oct 14, 2024

Conversation

RafilxTenfen
Copy link
Contributor

@RafilxTenfen RafilxTenfen commented Oct 9, 2024 •
edited
Loading

  • Create an interface to sign messages behind it
  • left a TODO to avoid export private key and use Sign(...

@RafilxTenfen RafilxTenfen self-assigned this Oct 9, 2024
@RafilxTenfen RafilxTenfen linked an issue Oct 9, 2024 that may be closed by this pull request
Refactor covenant emulator signing logic so that signing is hidden behind interface #18
Closed
@RafilxTenfen RafilxTenfen marked this pull request as ready for review October 9, 2024 19:49
gitferry
gitferry approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some naming suggestions:

covenant/expected_interfaces.go Outdated Show resolved Hide resolved
keyring/signer.go Outdated Show resolved Hide resolved
keyring/signer.go Outdated Show resolved Hide resolved
@RafilxTenfen RafilxTenfen requested a review from gitferry October 10, 2024 20:12
@RafilxTenfen
Copy link
Contributor Author

@gitferry asking to review again as I modified the interface to receive all the BTCDelegations at once and return the signatures, so each call of AddCovenantSignatures we only call once the signer.SignTransactions

KonradStaniec
KonradStaniec approved these changes Oct 12, 2024
View reviewed changes
covenant/expected_interfaces.go Outdated Show resolved Hide resolved
@KonradStaniec KonradStaniec self-requested a review October 12, 2024 15:01
gitferry
gitferry approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! No blocker apart from Konrad's comment

covenant/expected_interfaces.go Outdated Show resolved Hide resolved
cmd/covd/start.go Outdated Show resolved Hide resolved
cmd/covd/start.go Outdated Show resolved Hide resolved
covenant/covenant.go Outdated Show resolved Hide resolved
covenant/covenant.go Outdated Show resolved Hide resolved
@RafilxTenfen
Copy link
Contributor Author

I will wait for another review of @KonradStaniec to merge it

KonradStaniec
KonradStaniec approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating all comments 👍 looks good! just one minor question

covenant/covenant.go Outdated Show resolved Hide resolved
@RafilxTenfen RafilxTenfen merged commit e23e7d1 into main Oct 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradStaniec KonradStaniec KonradStaniec approved these changes

@gitferry gitferry gitferry approved these changes

Assignees

@RafilxTenfen RafilxTenfen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor covenant emulator signing logic so that signing is hidden behind interface
3 participants
@RafilxTenfen @gitferry @KonradStaniec